[webkit-reviews] review granted: [Bug 33427] Web Inspector: Do not repaint line numbers while editing within line. : [Attachment 46213] [PATCH] Proposed change

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 33427: Web Inspector: Do not repaint line numbers while editing within
line.
https://bugs.webkit.org/show_bug.cgi?id=33427

Attachment 46213: [PATCH] Proposed change
https://bugs.webkit.org/attachment.cgi?id=46213&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine
=== newRange.startLine)
> +	       // Nothing to repaint.
> +	       return;

This should have braces, even in the comment case, since it is multiline. See
style guide, Braces clause 3.