[webkit-reviews] review requested: [Bug 31169] Need to implement WebGLContextAttributes : [Attachment 46194] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 19:54:19 PST 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 31169: Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Attachment 46194: Patch
https://bugs.webkit.org/attachment.cgi?id=46194&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Added the WebGLContextAttributes class and custom JavaScript bindings to accept
a native object as the second argument to getContext("experimental-webgl") per
the WebGL specification. Passed new attributes object down through
HTMLCanvasElement::getContext to WebGLRenderingContext and GraphicsContext3D.
Added getContextAttributes() to WebGLRenderingContext. Added test case ensuring
that context attributes can be passed down and returned.  Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the OpenGL
context in bug 33416.


More information about the webkit-reviews mailing list