[webkit-reviews] review denied: [Bug 31597] locale for text breakiterator and string search is not set to the UI locale : [Attachment 46147] updated patch per darin's comment

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jungshik Shin <jshin at chromium.org>'s
request for review:
Bug 31597: locale for text breakiterator and string search is not set to the UI
locale
https://bugs.webkit.org/show_bug.cgi?id=31597

Attachment 46147: updated patch per darin's comment
https://bugs.webkit.org/attachment.cgi?id=46147&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #include "config.h"
> +#include "CString.h"
> +#include "Language.h"
> +#include "PlatformString.h"
>  #include "TextBreakIteratorInternalICU.h"

As the style-bot said, please add the new includes in a new paragraph after a
blank line. The file's own header goes first in the same paragraph with
config.h.


> +static const char* UILanguage() {

Brace goes on a separate line.

> +    // Chrome's UI language can be different from the OS UI language on
Windows.
> +    // We want to return Chrome's UI language here.
> +    static WebCore::CString locale;
> +    locale = WebCore::defaultLanguage().latin1();

This isn't quite right. The locale is a global variable, but you're
re-initializing it with new data every time through the function. Merging these
two lines of code into one will fix that.