[webkit-reviews] review denied: [Bug 33381] [Android] FrameLoaderClientAndroid::canHandleRequest needs to know whether the request was initiated by a user gesture : [Attachment 46138] Patch 1 for Bug 33381

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 10:22:27 PST 2010


Adam Barth <abarth at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 33381: [Android] FrameLoaderClientAndroid::canHandleRequest needs to know
whether the request was initiated by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=33381

Attachment 46138: Patch 1 for Bug 33381
https://bugs.webkit.org/attachment.cgi?id=46138&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This seems related to Bug 33188.  We're not accepting changes to FrameLoader
without tests.

Also, in general, you can't add new data members to ResourceRequestBase because
that class needs to round-trip all it's state through some CFNetwork object.  I
think the roundtriping requirement is dumb, but I've not succeeded in removing
it.


More information about the webkit-reviews mailing list