[webkit-reviews] review granted: [Bug 33353] [GTK] loading test should use SoupServer instead of actual sites : [Attachment 46097] proposed patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 33353: [GTK] loading test should use SoupServer instead of actual sites
https://bugs.webkit.org/show_bug.cgi?id=33353

Attachment 46097: proposed patch
https://bugs.webkit.org/attachment.cgi?id=46097&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+/* For real request testing */
>+static void
>+server_callback(SoupServer *server, SoupMessage *msg,
>+		  const char *path, GHashTable *query,
>+		  SoupClientContext *context, gpointer data)

This style issue you should fix at least.

BTW, I'm not sure I see any valid reason to not use the WebKit style in our
tests too. Not in this patch, but we should do it afterwards.

Everything else looks good to me, thanks for working on this.