[webkit-reviews] review requested: [Bug 33065] [chromium] Linux: add support for per-strike font render preferences : [Attachment 46091] Addressing fishd's comments

[bugzilla-daemon at webkit.org]

Adam Langley <agl at chromium.org> has asked  for review:
Bug 33065: [chromium] Linux: add support for per-strike font render preferences
https://bugs.webkit.org/show_bug.cgi?id=33065

Attachment 46091: Addressing fishd's comments
https://bugs.webkit.org/attachment.cgi?id=46091&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
> nit: indent by 4 spaces.
> kNoPreference should be NoPreference without the "k" prefix.

Done

> ^^^ nit: please insert a new line after familyForChars.

Done

> nit: isn't it better style to list out parameters last?  or perhaps this
should
> just be a return value?

I've moved the outarg to the end, although generally I disagree. Destinations
usually come first: memcpy, strcpy, '=' etc

> are there no constants that can be used in place of these magic numbers?

There's a great big comment in the .h file so I'm not too worried.

> nit: no need for the WebCore:: prefix above.

Done


Cheers