[webkit-reviews] review granted: [Bug 33348] REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report ) : [Attachment 46090] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 33348: REGRESSION (r48075): Clicking and dragging in a widget's text field
doesn't create a selection; drags widget instead ( Translation, Weather, Ski
Report )
https://bugs.webkit.org/show_bug.cgi?id=33348

Attachment 46090: Patch
https://bugs.webkit.org/attachment.cgi?id=46090&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebKit/mac/WebView/WebView.mm
> ===================================================================
> --- WebKit/mac/WebView/WebView.mm	(revision 52952)
> +++ WebKit/mac/WebView/WebView.mm	(working copy)
> @@ -1301,6 +1301,8 @@ static bool fastDocumentTeardownEnabled(
>      settings->setApplicationChromeMode([preferences
applicationChromeModeEnabled]);
>      if ([preferences userStyleSheetEnabled]) {
>	   NSString* location = [[preferences userStyleSheetLocation]
_web_originalDataAsString];
> +	   if ([location isEqual:@"apple-dashboard://stylesheet"])

Prefer isEqualToString.

r=me