[webkit-reviews] review granted: [Bug 32909] [Windows] Printing of Plugins Ignores Header Settings When Calculating Page Position : [Attachment 45941] Patch to update CTM with scale and position when drawing a plugin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 14:00:46 PST 2010


Jon Honeycutt <jhoneycutt at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 32909: [Windows] Printing of Plugins Ignores Header Settings When
Calculating Page Position
https://bugs.webkit.org/show_bug.cgi?id=32909

Attachment 45941: Patch to update CTM with scale and position when drawing a
plugin
https://bugs.webkit.org/attachment.cgi?id=45941&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 52752)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,16 @@
> +2010-01-05  Brent Fulgham  <bfulgham at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Scale device context world transform passed to plugins to account
> +	   for print surface DPI.
> +	   http://bugs.webkit.org/show_bug.cgi?id=33022.

This mentions a different bug #.

Is there a similar change that needs to be made for windowless plug-ins?

Is there any way to add a test this? Perhaps a manual test?

r=me


More information about the webkit-reviews mailing list