[webkit-reviews] review granted: [Bug 32641] The selected property of <option> elements is not always up to date : [Attachment 46080] Much better patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 7 13:34:55 PST 2010
Alexey Proskuryakov <ap at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 32641: The selected property of <option> elements is not always up to date
https://bugs.webkit.org/show_bug.cgi?id=32641
Attachment 46080: Much better patch
https://bugs.webkit.org/attachment.cgi?id=46080&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> static void menuListDefaultEventHandler(SelectElementData&, Element*,
Event*, HTMLFormElement*);
> static void listBoxDefaultEventHandler(SelectElementData&, Element*,
Event*, HTMLFormElement*);
> + static void setOptionsChangedOnRenderer(SelectElementData& data,
Element* element);
Argument names are not needed here.
r=me
More information about the webkit-reviews
mailing list