[webkit-reviews] review granted: [Bug 33084] Fix for RVCT -Otime fatal compiler error : [Attachment 45714] Updated patch for 33084 to fix tab issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 7 12:43:36 PST 2010
Darin Adler <darin at apple.com> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 33084: Fix for RVCT -Otime fatal compiler error
https://bugs.webkit.org/show_bug.cgi?id=33084
Attachment 45714: Updated patch for 33084 to fix tab issue
https://bugs.webkit.org/attachment.cgi?id=45714&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
I would prefer the name "entry" to the letter "e".
I would prefer that each call site has a brief comment like this one:
// Use a local variable here to sidestep an RVCT compiler bug.
I withdraw my earlier exception because you say these are the only 4 sites that
need to be patched.
r=me as is
More information about the webkit-reviews
mailing list