[webkit-reviews] review denied: [Bug 33331] WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins : [Attachment 46067] proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 11:31:52 PST 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kevin Decker
<kdecker at apple.com>'s request for review:
Bug 33331: WebHostedNetscapePluginView should pass
acceleratedCompositingEnabled bool to NetscapePluginHostManager when
instantiating plug-ins
https://bugs.webkit.org/show_bug.cgi?id=33331

Attachment 46067: proposed fix.
https://bugs.webkit.org/attachment.cgi?id=46067&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
>      _proxy =
NetscapePluginHostManager::shared().instantiatePlugin(_pluginPackage.get(),
self, _MIMEType.get(), _attributeKeys.get(), _attributeValues.get(), userAgent,
_sourceURL.get(), 
> -								      _mode ==
NP_FULL, _isPrivateBrowsingEnabled);
> +								      _mode ==
NP_FULL, _isPrivateBrowsingEnabled, [[[self webView] preferences]
acceleratedCompositingEnabled]);

This also needs to check USE(ACCELERATED_COMPOSITING).


More information about the webkit-reviews mailing list