[webkit-reviews] review granted: [Bug 17248] :nth-child() and :lang() should allow spaces before, after and inside the expression : [Attachment 46021] Allow leading/trailing space for CSS :nth-*() and :lang()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 17248: :nth-child() and :lang() should allow spaces before, after and
inside the expression
https://bugs.webkit.org/show_bug.cgi?id=17248

Attachment 46021: Allow leading/trailing space for CSS :nth-*() and :lang()
https://bugs.webkit.org/attachment.cgi?id=46021&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Two thoughts on how to improve in the future or with a followup:

    1) This doesn't need to be a non-text test. It would be good to make a test
of this that dumps as text instead of a render tree. There are plenty of ways
to check that CSS has been parsed other than actually dumping out the render
tree.

    2) We should have a test of the "spaces inside the expression" case, even
though we're not changing behavior of that. We want to test all the significant
cases, and that clearly is significant, given the discussion in this bug.