[webkit-reviews] review requested: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 46047] Repaint only the invalidated area after scrolling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 05:13:08 PST 2010


Benjamin Poulain <benjamin.poulain at nokia.com> has asked  for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 46047: Repaint only the invalidated area after scrolling
https://bugs.webkit.org/attachment.cgi?id=46047&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
Patch updates to apply the comments of Kenneth:

> > > I dislike the method name. Shouldn't it always be fast? 
> > 
> scrollContentsFastPath :-) ?

Done.

> OK. maybe invalidated is better than invalid.

Done

> I wonder if it would be better to use addFixedObject and removeFixedObject
> instead as we use add/remove elsewhere (like addSlowRepaintObject)

I choose the name register to emphasize the fact that you only register some
fixed object. I am afraid that with addFixedObject(), it might be understood
that all objects have to be registered.


More information about the webkit-reviews mailing list