[webkit-reviews] review denied: [Bug 27032] document.title does not replace or remove space characters : [Attachment 45961] Updated final(?) patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 6 23:01:36 PST 2010
Eric Seidel <eric at webkit.org> has denied review:
Bug 27032: document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032
Attachment 45961: Updated final(?) patch
https://bugs.webkit.org/attachment.cgi?id=45961&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Failure seen on the commit-bot:
--- /tmp/layout-test-results/fast/dom/Document/document-title-get-expected.txt
2010-01-06 20:23:24.000000000 -0800
+++ /tmp/layout-test-results/fast/dom/Document/document-title-get-actual.txt
2010-01-06 20:23:24.000000000 -0800
@@ -11,8 +11,6 @@
PASS document.title is ""
Test with no whitespace
PASS document.title is "nowhitespacetitle"
-Test with Unicode whitespace in the space separator category
-PASS document.title is "one space"
Test with whitespace
PASS document.title is "one space"
Test with various whitespace lengths and fields
Looks like this patch is going to need one more round of update. Marking r-
since it would cause a test to fail as is.
More information about the webkit-reviews
mailing list