[webkit-reviews] review granted: [Bug 33269] Improve HTMLElement::tagPriority() : [Attachment 45999] Proposed patch (rev.2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 16:26:36 PST 2010


Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 33269: Improve HTMLElement::tagPriority()
https://bugs.webkit.org/show_bug.cgi?id=33269

Attachment 45999: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=45999&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +// TagPriorityMap returns 1 for unregistered tags. It's same as <span>.
> +// This way custom tag name elements will behave like inline spans.

I think this comment should be at the bottom of initializeTagPriorityMap.

> +static const TagPriorityMap* initializeTagPriorityMap()

Given that this actually creates the map too, I suggest naming it
createTagPriorityMap.

r=me assuming that localName().impl() is *not* ever 0

If it can be zero, then this patch is not OK.


More information about the webkit-reviews mailing list