[webkit-reviews] review requested: [Bug 32846] Timeline Panel timings are polluted by DOM Mutation events (which force inline Style Recalculations) : [Attachment 46006] Removes DOM mutation listeners and adds direct calls to inspector.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 16:01:58 PST 2010


Kelly Norton <knorton at google.com> has asked  for review:
Bug 32846: Timeline Panel timings are polluted by DOM Mutation events (which
force inline Style Recalculations)
https://bugs.webkit.org/show_bug.cgi?id=32846

Attachment 46006: Removes DOM mutation listeners and adds direct calls to
inspector.
https://bugs.webkit.org/attachment.cgi?id=46006&action=review

------- Additional Comments from Kelly Norton <knorton at google.com>
Couple of notes about this patch:

(1) It leaves the listeners for load and DOMContentLoaded as they were in
InspectorDOMAgent. There really is no need to remove these listeners as they
don't interfere like mutation events do.

(2) Attr mutations are now pushed into the front-end, but the front-end doesn't
have events setup to update the ElementPanel when attributes are mutated. I did
not fix this yet. I figured I would just do it after this one goes in.


More information about the webkit-reviews mailing list