[webkit-reviews] review denied: [Bug 33271] Number of repaint tests need new pixel results due to r52839 : [Attachment 45997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 14:53:05 PST 2010


mitz at webkit.org has denied James Robinson <jamesr at chromium.org>'s request for
review:
Bug 33271: Number of repaint tests need new pixel results due to r52839
https://bugs.webkit.org/show_bug.cgi?id=33271

Attachment 45997: Patch
https://bugs.webkit.org/attachment.cgi?id=45997&action=review

------- Additional Comments from mitz at webkit.org
> Index: WebKitTools/Scripts/webkitpy/credentials.py
> ===================================================================
> --- WebKitTools/Scripts/webkitpy/credentials.py	(revision 52868)
> +++ WebKitTools/Scripts/webkitpy/credentials.py	(working copy)
> @@ -96,8 +96,8 @@ class Credentials(object):
>	   if Git.in_working_directory(self.cwd):
>	       (username, password) = self._credentials_from_git()
>  
> -	   if not username or not password:
> -	       (username, password) = self._credentials_from_keychain(username)

> +#	    if not username or not password:
> +#		(username, password) =
self._credentials_from_keychain(username)
>  
>	   if not username:
>	       username = raw_input("%s login: " % self.host)

This looks irrelevant.


More information about the webkit-reviews mailing list