[webkit-reviews] review denied: [Bug 33186] Track state for whether a ResourceRequest is fetched via SPDY : [Attachment 45977] Remove ifdef CHROMIUM flag as per David's suggestion
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 6 13:23:58 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Mike Belshe
<mbelshe at chromium.org>'s request for review:
Bug 33186: Track state for whether a ResourceRequest is fetched via SPDY
https://bugs.webkit.org/show_bug.cgi?id=33186
Attachment 45977: Remove ifdef CHROMIUM flag as per David's suggestion
https://bugs.webkit.org/attachment.cgi?id=45977&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/platform/network/chromium/ResourceResponse.h
...
> + // If this request was fetched via SPDY.
> + bool m_isSpdy;
How about naming this m_fetchedViaSPDY? Then, the comment can be
deleted. You should similarly rename the getter and setter.
Same goes for the corresponding WebURLResponse methods.
With those changes, LGTM.
More information about the webkit-reviews
mailing list