[webkit-reviews] review granted: [Bug 32898] [Qt] Add page zooming support to Qt DumpRenderTree : [Attachment 45979] Proposed patch v0.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 12:35:44 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 32898: [Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898

Attachment 45979: Proposed patch v0.2
https://bugs.webkit.org/attachment.cgi?id=45979&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +	   Patch by Kim Grönholm  <kim.gronholm at nomovok.com>,

Please make sure his name is written correct. Did you upload the patch with
bugzilla-tool?


>  
> +#define ZOOM_STEP	       1.2
>  

Why 1.2 and not 1.3? Please add a comment explaining why (required by DRT?)


More information about the webkit-reviews mailing list