[webkit-reviews] review requested: [Bug 32875] [Android] Android requires ability to increase layout delay : [Attachment 45970] Patch 2 for Bug 32875

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has asked  for review:
Bug 32875: [Android] Android requires ability to increase layout delay
https://bugs.webkit.org/show_bug.cgi?id=32875

Attachment 45970: Patch 2 for Bug 32875
https://bugs.webkit.org/attachment.cgi?id=45970&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> > +	 m_extraLayoutDelay = 0;
> Should use member initialization syntax instead of assignment.
I used assignment to keep this variable with the other variables used in
minimumLayoutDelay(), which are
initialized in this way. Do you want me to move the entire group to the
initializer list?
 
> In the .cpp file you probably need a comment mentioning this is used by
> Android. Otherwise, someone may remove this unused function.
Fixed.

> I don't understand why minimumLayoutDelay returns an int.  It should be
> unsigned I would think.
It looks like there are plenty of cases (in this file and elsewhere) where int
is used for values which will always be non-negative and I don't think this is
the place to fix them all.

> I also think m_extraLayoutDelay should have a comment enxt to it in
Document.h
> explaining what it's used for.
Fixed