[webkit-reviews] review denied: [Bug 33252] Allow custom memory allocation control for IconDatabaseClient class : [Attachment 45960] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 6 09:00:01 PST 2010
Eric Seidel <eric at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 33252: Allow custom memory allocation control for IconDatabaseClient class
https://bugs.webkit.org/show_bug.cgi?id=33252
Attachment 45960: proposed patch
https://bugs.webkit.org/attachment.cgi?id=45960&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This is an Abstract Base Class. I don't think that this interface should
require non-copyable. The implementors of this interface should inherit from
NonCopyable or FastAllocBase instead, no?
More information about the webkit-reviews
mailing list