[webkit-reviews] review requested: [Bug 32971] check-webkit-style: Move and rename style-related files into webkitpy/style folder : [Attachment 45963] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 08:48:43 PST 2010


Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 32971: check-webkit-style: Move and rename style-related files into
webkitpy/style folder
https://bugs.webkit.org/show_bug.cgi?id=32971

Attachment 45963: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45963&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
To reference webkitpy modules outside of webkitpy/style, I settled on the
central approach of adding the parent webkitpy directory to the style package's
search path in style/__init__.py.  This is instead of using absolute or
relative import statements throughout the style package.

This comes up, for example, when style/checker.py needs to import
diff_parser.DiffParser.

This will minimize us needing to go in an update files in the style package as
the folder hierarchy for non-style files changes.  Let me know if you have
other thoughts.


More information about the webkit-reviews mailing list