[webkit-reviews] review requested: [Bug 33193] [V8] CodeGeenratorV8 can't find item() or namedItem() in parent classes : [Attachment 45953] Proposed patch (rev.2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 20:40:16 PST 2010


TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 33193: [V8] CodeGeenratorV8 can't find item() or namedItem() in parent
classes
https://bugs.webkit.org/show_bug.cgi?id=33193

Attachment 45953: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=45953&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
(In reply to comment #6)
> Thanks so much for picking finding this! However, I don't think this is the
> right approach. We should instead work on making our template configuration
> aware of inheritance.
> 
> In the meantime, let's just add an exception to GenerateImplementationIndexer

> (see HTMLOptionCollection).

Thank you for the comment.
Ok, the updated patch just adds a workaround for WebKitCSSTransformValue.


More information about the webkit-reviews mailing list