[webkit-reviews] review requested: [Bug 32689] Fix the leak of ThreadIdentifiers in threadMap across threads. : [Attachment 45951] Patch with test.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 18:00:07 PST 2010
Dmitry Titov <dimich at chromium.org> has asked for review:
Bug 32689: Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689
Attachment 45951: Patch with test.
https://bugs.webkit.org/attachment.cgi?id=45951&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Same change, with a test.
See DumRenderTree.mm and WebKitTools/ChangeLog for the description of the test.
Basically, it starts couple of trivial threads that use WTF::currentThread()
method. Without the fix, there are at least 2 ASSERTS on the way of DRT to
completion.
It simulates scenarios when embedders like Safari run threads not created by
WTF that call into JSC/WebKit code which can use currentThread(), or DRT
running with '--threaded', to name a couple.
More information about the webkit-reviews
mailing list