[webkit-reviews] review canceled: [Bug 28459] bugzilla-tool needs a new name : [Attachment 45937] Adam's requested proof-of-concept of adding a clone tool with the same name.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 16:23:38 PST 2010


Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 28459: bugzilla-tool needs a new name
https://bugs.webkit.org/show_bug.cgi?id=28459

Attachment 45937: Adam's requested proof-of-concept of adding a clone tool with
the same name.
https://bugs.webkit.org/attachment.cgi?id=45937&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Forgot to pass --no-review.

I think I'm OK with just renaming bugzilla-tool to webkit-patch.  Yes, it sucks
that webkit-patch will have a bunch of unrelated crap in it.  Yes, people will
get confused about what bugzilla-tool is called.  Yes, we'll have to re-start
all of our scripts.  But I'm less and less sure that having separate tools buys
us much.  We could continue down the path of this patch, and with only a little
more code restrict the commands which are exposed under webkit-patch.  But I'm
not sure it buys us much.


More information about the webkit-reviews mailing list