[webkit-reviews] review denied: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 45892] Repaint only the invalidated area after scrolling

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 45892: Repaint only the invalidated area after scrolling
https://bugs.webkit.org/attachment.cgi?id=45892&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
There are a number of issues with this patch:

(1) ScrollView is not designed to know anything about the render tree or
RenderObjects directly.  I'd move the HashSet to FrameView and then make a
virtual method that is called in ScrollView.

(2) Please make a constant for the cutoff number in the code.  Don't just use 5
inline like that.

(3) You should disregard fixed positioned objects inside transforms, as they
aren't actually fixed to the ScrollView.  You can verify this by checking if
the containingBlock is actually the RenderView for each RenderObject before
allowing it to be registered.

(4) Why not make fixed background images work too?  They are just as common (if
not moreso) than fixed positioning.