[webkit-reviews] review granted: [Bug 32987] Add build option ENABLE_XHTMLMP to Mac, GTK, and Chromium build systems : [Attachment 45817] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 13:24:59 PST 2010
Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 32987: Add build option ENABLE_XHTMLMP to Mac, GTK, and Chromium build
systems
https://bugs.webkit.org/show_bug.cgi?id=32987
Attachment 45817: Patch
https://bugs.webkit.org/attachment.cgi?id=45817&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Assuming HTMLNoScriptElement is appropriately guarded, this looks fine.
configure.ac looks insanely verbose and redundant.
Your ChangeLogs need lovin before you can land this:
+ Need a short description and bug URL (OOPS!)
+
+ No new tests. (OOPS!)
+
More information about the webkit-reviews
mailing list