[webkit-reviews] review granted: [Bug 33228] Line boxes aren't cleared when the last child is removed from a RenderBlock : [Attachment 45924] Clears lineboxes when last child is deleted
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 13:16:31 PST 2010
Dave Hyatt <hyatt at apple.com> has granted James Robinson <jamesr at chromium.org>'s
request for review:
Bug 33228: Line boxes aren't cleared when the last child is removed from a
RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=33228
Attachment 45924: Clears lineboxes when last child is deleted
https://bugs.webkit.org/attachment.cgi?id=45924&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Seems like this should be:
if (childrenInline() && !firstChild())
just to not waste time calling into lineBoxes() in the block child removal
case?
r=me
More information about the webkit-reviews
mailing list