[webkit-reviews] review denied: [Bug 33159] Make JSObject::getPropertyNames() non-virtual : [Attachment 45807] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 12:59:24 PST 2010
Geoffrey Garen <ggaren at apple.com> has denied Kent Hansen
<kent.hansen at nokia.com>'s request for review:
Bug 33159: Make JSObject::getPropertyNames() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=33159
Attachment 45807: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45807&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This patch looks promising, but I agree with Darin: refactoring and potential
behavior changes should be separate patches. I'll respond to your specific
questions in a separate post.
More information about the webkit-reviews
mailing list