[webkit-reviews] review denied: [Bug 33222] Make text decoders and resource loaders read from segmented SharedBuffer : [Attachment 45914] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 12:16:22 PST 2010


Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 33222: Make text decoders and resource loaders read from segmented
SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=33222

Attachment 45914: the patch
https://bugs.webkit.org/attachment.cgi?id=45914&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think it woudl be better to write two new functions.	One which does this
loop and calls didRecievData on a passed in subresourceloader, and the other
which does the loop and calls decode on a passed in decoder and returns the
final string.  That saves us from any copy/paste code.


More information about the webkit-reviews mailing list