[webkit-reviews] review requested: [Bug 33219] Add assertions to catch double-destruction of WebViews earlier : [Attachment 45909] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 33219: Add assertions to catch double-destruction of WebViews earlier
https://bugs.webkit.org/show_bug.cgi?id=33219

Attachment 45909: Patch
https://bugs.webkit.org/attachment.cgi?id=45909&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.
---
 3 files changed, 32 insertions(+), 1 deletions(-)