[webkit-reviews] review granted: [Bug 33200] Generate list of Perl unit test files dynamically : [Attachment 45887] Proposed patch 2

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33200: Generate list of Perl unit test files dynamically
https://bugs.webkit.org/show_bug.cgi?id=33200

Attachment 45887: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=45887&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebKitTools/Scripts/test-webkitperl
> ===================================================================
> --- WebKitTools/Scripts/test-webkitperl	(revision 52795)
> +++ WebKitTools/Scripts/test-webkitperl	(working copy)
> @@ -30,23 +30,20 @@
>  
>  # Runs unit tests of WebKit Perl code.
>  
> +use strict;
> +use warnings;

Adding "-w" to the "#!/usr/bin/perl" line actually catches slightly more issues
than "use warnings" (IIRC), but I don't think it really matters for this
script.

r=me