[webkit-reviews] review granted: [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block : [Attachment 45900] fix build warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 09:35:14 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Yong Li
<yong.li.webkit at gmail.com>'s request for review:
Bug 33178: Segmented SharedBuffer: SharedBuffer doesn't have to be a flat
memory block
https://bugs.webkit.org/show_bug.cgi?id=33178

Attachment 45900: fix build warnings
https://bugs.webkit.org/attachment.cgi?id=45900&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    unsigned bytesToCopy = static_cast<unsigned>(length) < segmentFreeSpace
? static_cast<unsigned>(length) : segmentFreeSpace;
> +    unsigned bytesToCopy = std::min(length, segmentFreeSpace);

Our style is to put "using namespace std;" at the top of the file and then omit
the "std::" qualifier.

Other than that, this looks good.

r=me if you fix that before committing.


More information about the webkit-reviews mailing list