[webkit-reviews] review denied: [Bug 33200] Generate list of Perl unit test files dynamically : [Attachment 45869] Proposed patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33200: Generate list of Perl unit test files dynamically
https://bugs.webkit.org/show_bug.cgi?id=33200

Attachment 45869: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=45869&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
These changes look fine, but I noticed that the script isn't using strict mode
and doesn't have warnings enabled:

> Index: WebKitTools/Scripts/test-webkitperl

- #/usr/bin/perl
+ #/usr/bin/perl -w

> @@ -30,6 +30,7 @@
>  
>  # Runs unit tests of WebKit Perl code.

+ use strict;

> +use File::Spec;
>  use FindBin;
>  use Test::Harness;
>  use lib $FindBin::Bin; # so this script can be run from any directory.

These two changes will require all variables to be declared (using 'my'). 
Sorry I didn't catch this earlier!