[webkit-reviews] review granted: [Bug 32568] Web Inspector: Context Menus should be used in more places : [Attachment 45865] [PATCH] Context Menus for Breakpoints

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 00:23:41 PST 2010


Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 32568: Web Inspector: Context Menus should be used in more places
https://bugs.webkit.org/show_bug.cgi?id=32568

Attachment 45865: [PATCH] Context Menus for Breakpoints
https://bugs.webkit.org/attachment.cgi?id=45865&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   if (!sourceRow._breakpointObject && this.addBreakpointDelegate) {

Should you check for this.addBreakpointDelegate in the else condition too so it
is balanced?


More information about the webkit-reviews mailing list