[webkit-reviews] review granted: [Bug 33125] Use OptionParser instead of getopt in test-webkit-script : [Attachment 45864] Proposed patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 5 00:03:40 PST 2010
Eric Seidel <eric at webkit.org> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33125: Use OptionParser instead of getopt in test-webkit-script
https://bugs.webkit.org/show_bug.cgi?id=33125
Attachment 45864: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=45864&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Adam convinced me to standardize on " instead of ' (even though I personally
prefer '), I think this is fine as-is, but in the future you should consider
using ". As far as I can tell the python style guide expresses no preference,
but using one over the other makes search/replace slightly easier.
LGTM.
More information about the webkit-reviews
mailing list