[webkit-reviews] review denied: [Bug 33188] ER: Need a way to know when FrameLoader is loading a URL based on user action : [Attachment 45848] Patch v1

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 33188: ER: Need a way to know when FrameLoader is loading a URL based on
user action
https://bugs.webkit.org/show_bug.cgi?id=33188

Attachment 45848: Patch v1
https://bugs.webkit.org/attachment.cgi?id=45848&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
We aren't accepting FrameLoader patches without tests.

That said, this code is wrong, mostly because all our user gesture code is
wrong.	Why is frame->script()->processingUserGesture() insufficient?  I think
the correct fix is to teach that function to return the correct answer.

Basically, the right way to do this is when an event enters WebKit (or maybe
WebCore), we know whether it's a real user input event or a fake event.  At
that time, we should create a scoped object that stores the user gesture state
in a static.  script()->processingUserGesture should then read the static.  The
current approach of trying to recover the information from Event is wrong and
doesn't work in edge cases.