[webkit-reviews] review granted: [Bug 33189] scaleEmToUnits in SimpleFontDataMac.mm does an unnecessary division : [Attachment 45856] Patch without static_cast for real this time.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 18:58:46 PST 2010


mitz at webkit.org has granted Ojan Vafai <ojan at chromium.org>'s request for
review:
Bug 33189: scaleEmToUnits in SimpleFontDataMac.mm does an unnecessary division
https://bugs.webkit.org/show_bug.cgi?id=33189

Attachment 45856: Patch without static_cast for real this time.
https://bugs.webkit.org/attachment.cgi?id=45856&action=review

------- Additional Comments from mitz at webkit.org
> +	   Need a short description and bug URL (OOPS!)

Please remove that line.

> +	   No new tests. Covered by existing tests.

More like this code change does not change behavior.


More information about the webkit-reviews mailing list