[webkit-reviews] review granted: [Bug 33178] Segmented SharedBuffer: SharedBuffer doesn't have to be a flat memory block : [Attachment 45830] (1) make SharedBuffer use segments internally

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 33178: Segmented SharedBuffer: SharedBuffer doesn't have to be a flat
memory block
https://bugs.webkit.org/show_bug.cgi?id=33178

Attachment 45830: (1) make SharedBuffer use segments internally
https://bugs.webkit.org/attachment.cgi?id=45830&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +static unsigned segmentIndex(unsigned position)
> +{
> +    return position / segmentSize;
> +}
> +
> +static unsigned offsetInSegment(unsigned position)
> +{
> +    return position & segmentPositionMask;
> +}

Should probably say "inline" in both of these.

> +unsigned SharedBuffer::getSomeData(const char*& someData, unsigned pos)
const

Would prefer "position" or "offset" to "pos".

r=me