[webkit-reviews] review granted: [Bug 30435] Update media layout tests to be codec aware and a V8 binding fix. : [Attachment 45833] Round 6 + proper ChangeLog

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 30435: Update media layout tests to be codec aware and a V8 binding fix.
https://bugs.webkit.org/show_bug.cgi?id=30435

Attachment 45833: Round 6 + proper ChangeLog
https://bugs.webkit.org/attachment.cgi?id=45833&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

> +	   * platform/mac-leopard/media/video-no-audio-expected.checksum: New
results due to changing source video.
> +	   * platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
> +	   * platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.

You should check these in for SnowLeopard as well. 


> -    waitForEvent("loadstart", function () {
testExpected("relativeURL(audio.currentSrc)", "content/test.wav"); });
> +    waitForEvent("loadstart", function () {
testExpected("relativeURL(audio.currentSrc)", audioFile); });

Eric's comment is correct. While all ports support wav at the moment, the spec
doesn't require it so you should change this to use findMediaFile(). 


> diff --git
a/LayoutTests/platform/mac-leopard/media/video-no-audio-expected.png
b/LayoutTests/platform/mac-leopard/media/video-no-audio-expected.png
> index
208d4788bdc6f6338561ea69aa9afd31e24b6202..e6b4ec557a2560b4e58d0afa28b3f6f470bd6
5b3 100644
> GIT binary patch
> literal 20611

> 
> literal 21975

Do you need to set the svn:mime-type on these files somehow?

r=me with these changes.