[webkit-reviews] review granted: [Bug 30098] commit-queue can wrongly reject patches if the buildbots are behind : [Attachment 45835] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 15:06:28 PST 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 30098: commit-queue can wrongly reject patches if the buildbots are behind
https://bugs.webkit.org/show_bug.cgi?id=30098

Attachment 45835: Patch
https://bugs.webkit.org/attachment.cgi?id=45835&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

Slightly confused by the second _builders_are_green() check?  (might need a
comment?)  Won't land-attachment check for us?

I still need to fix buildbot to be able to tell you if things are pending. 
I'll do that in a separate bug.


More information about the webkit-reviews mailing list