[webkit-reviews] review granted: [Bug 33164] [WinCairo] Improper Cairo Surface Type Sometimes Used : [Attachment 45811] Check bitmap validity, only construct 32-bit surface when needed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 12:08:13 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 33164: [WinCairo] Improper Cairo Surface Type Sometimes Used
https://bugs.webkit.org/show_bug.cgi?id=33164

Attachment 45811: Check bitmap validity, only construct 32-bit surface when
needed.
https://bugs.webkit.org/attachment.cgi?id=45811&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    if (!GetObject(bitmap, sizeof(info), &info))
> +	   surface = cairo_win32_surface_create(hdc);

Does this surface have an associated bitmap? Do we need to select it into the
DC?

Please add a link to this bug in the ChangeLog.

r=me


More information about the webkit-reviews mailing list