[webkit-reviews] review denied: [Bug 32841] [Chromium] Adding new methods to the Chromium DOM API : [Attachment 45389] 45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 4 11:03:48 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Campan
<jcampan at google.com>'s request for review:
Bug 32841: [Chromium] Adding new methods to the Chromium DOM API
https://bugs.webkit.org/show_bug.cgi?id=32841
Attachment 45389: 45350: Adding some extra methods to the Chromium DOM API
(needed for the translate feature)
https://bugs.webkit.org/attachment.cgi?id=45389&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/WebElement.cpp
...
> +WebString WebElement::getTagName() const
> +{
> + return constUnwrap<Element>()->tagName();
Please change WebElement::getTagName to just tagName. WebKit
style avoids "get"
Otherwise, LGTM
-Darin
More information about the webkit-reviews
mailing list