[webkit-reviews] review granted: [Bug 33088] MSAA: <select> elements should broadcast value change events : [Attachment 45730] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 33088: MSAA: <select> elements should broadcast value change events
https://bugs.webkit.org/show_bug.cgi?id=33088

Attachment 45730: patch
https://bugs.webkit.org/attachment.cgi?id=45730&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    enum PostType { PostSynchronously, PostAsynchronously };
> +    void postNotification(RenderObject*, AXNotification, bool postToElement,
PostType = PostAsynchronously);

One the one hand, it's good to not pollute the global WebCore namespace with
something like PostType. But on the other, the whole point of such enums is to
make code more readable, and if call sites have to utter
AXObjectCache::PostSynchronously it's pretty awkward. I suggest moving such
enums out of the class.

r=me as is though