[webkit-reviews] review denied: [Bug 33127] Missing Test Outputs for MathML and License Updates : [Attachment 45764] The patch for updating the license header and adding the test outputs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 3 20:42:17 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied  review:
Bug 33127: Missing Test Outputs for MathML and License Updates
https://bugs.webkit.org/show_bug.cgi?id=33127

Attachment 45764: The patch for updating the license header and adding the test
outputs
https://bugs.webkit.org/attachment.cgi?id=45764&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Oops, I take the r+ back. Obviously the pixel test results can't be reproduced
without the actual code that renders them. So there's no point in landing it
before.
I got on the wrong track as the ChangeLog indicates that the pixel test results
are missing, that's true, but the results that you created don't match trunk.
You probably need to regenerate the results without your other patches applied
(against a fresh trunk tree). Those could be landed, as they are really
missing.


More information about the webkit-reviews mailing list