[webkit-reviews] review denied: [Bug 33084] Fix for RVCT -Otime fatal compiler error : [Attachment 45714] Updated patch for 33084 to fix tab issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 3 18:14:33 PST 2010


Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 33084: Fix for RVCT -Otime fatal compiler error
https://bugs.webkit.org/show_bug.cgi?id=33084

Attachment 45714: Updated patch for 33084 to fix tab issue
https://bugs.webkit.org/attachment.cgi?id=45714&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Have we filed a bug about this with RVCT?  There will be a zillion of these. 
Every ::create() impelmentation in WebCore will have this problem as:
return adoptRef(new Foo);
 is how we create objects in Foo::create().

This definitely needs a RVCT bug number and more explanation. I don't think
you're going to get far with this type of change in WebCore.


More information about the webkit-reviews mailing list