[webkit-reviews] review granted: [Bug 33091] SVGResources don't invalidate if target object changes attributes : [Attachment 45760] Resource invalidation on attribute changes of target object

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 33091: SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091

Attachment 45760: Resource invalidation on attribute changes of target object
https://bugs.webkit.org/attachment.cgi?id=45760&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks almost fine, please change following before landing:

> +void SVGStyledElement::invalidateResources()
> +{
Retrieve document via DOM, not render tree, and early exit when parsing:
Document* document = this->document();
if (!document->parsing())
    return;

You could also use "doc", and save the "this->", but I think it's a stylerule
to not use abbreviations, if possible, so let's enforce it.

r=me.