[webkit-reviews] review requested: [Bug 24021] pseudo-element styles not accessible / retrievable via DOM methods : [Attachment 45754] A tentative idea for a fix that will expose the standard pseudo-elements through getComputedStyle

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has asked  for review:
Bug 24021: pseudo-element styles not accessible / retrievable via DOM methods
https://bugs.webkit.org/show_bug.cgi?id=24021

Attachment 45754: A tentative idea for a fix that will expose the standard
pseudo-elements through getComputedStyle
https://bugs.webkit.org/attachment.cgi?id=45754&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
I would highly appreciate feedback on the general approach.

 As I write in the ChangeLog, there are several parts of this patch that I am
mildly uncomfortable with:

	1) The need to duplicate the pseudo style string to pseudo style
constant
	   mapping that is done in CSSSelector::extractPseudoType(). I was
unable
	   to find a mapping between PseudoType and PseudoId and decided it
made
	   mores sense to map from the string itself to the PseudoId
	2) This patch won't give the desired results for the -webkit-scrollbar
	   pseudo-elements.
	3) I am not sure that going directly to the renderer is correct.
Looking
	   in Element::computedStyle(), there seems to be an option for
elements
	   like HTMLOptionElement to not have renderers. I am not exactly sure
	   why this is.