[webkit-reviews] review requested: [Bug 33039] [bzt] Bugzilla-tool dies with an error if it cannot find a keychain entry for bugs.webkit.org : [Attachment 45752] Patch with unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 14:32:38 PST 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 33039: [bzt] Bugzilla-tool dies with an error if it cannot find a keychain
entry for bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=33039

Attachment 45752: Patch with unit test
https://bugs.webkit.org/attachment.cgi?id=45752&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Modified the unit test method
CredentialsTest.test_security_output_parse_entry_not_found() to call
Credentials._is_mac_os_x() instead of querying for the platform info. directly.
Also, added a comment to explain why we are ignoring the captured output.


More information about the webkit-reviews mailing list