[webkit-reviews] review requested: [Bug 33098] Refactor svn-apply and svn-unapply to use a common "patch" method : [Attachment 45747] Proposed patch 3

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 33098: Refactor svn-apply and svn-unapply to use a common "patch" method
https://bugs.webkit.org/show_bug.cgi?id=33098

Attachment 45747: Proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=45747&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
Lots more changes here for the better (many relating to your suggestions),
including--

- Broke the code to assemble the patch command syntax out into a separate 
  subroutine for cleaner testing, and added a bunch of unit tests.
- Broke out the optional arguments to runPatchCommand() into a hash
  reference (named parameters) since the argument list was getting longer.
- Moved more code from applyPatch/unapplyPatch into runPatchCommand().
- Removed from the unit tests the reference to /dev/null, so the bad patch
  test is more likely to work on Windows now.
- Added unit tests to test successful patches (both silent and "real").
- svn-unapply now returns a non-zero exit status if one of the patches
  failed (it didn't before, since it was effectively always in --force mode).